← Back to team overview

woda team mailing list archive

Re: possible bug with default format

 

Hi Malcolm

Sorry, I forgot that format;DEFAULT doesn't define head and foot.

Have you noticed that format;DEFAULT is still widely used in woda engine? 
strange!...
xavier
 
Le mercredi 14 octobre 2009 02:53:10, vous avez écrit :
> Hi Xavier,
> 
> I was experiencing a problem that I was having trouble tracing. The
> code was producing bad HTML in some situations. My solution was to
> ensure that there was always clean HTML code produced. The user could
> then modify the result using CSS rules or javaScript.
> 
> Quoting Xavier Brochard <xavier@xxxxxxxxxxxxxx>:
> > Hi Malcolm
> >
> >
> > In the code below, you have changed how formatHead/FootDEFAULT is
> > defined:
> >
> >     # --- defaults and compatibility issues
> > (...)
> >     if ( $WBB{'formatRowDEFAULT'} eq '' && $WBB{'format;DEFAULT'} ne '' )
> > { # $WBB{'formatRowDEFAULT'} = $WBB{"format;DEFAULT"};
> >         $WBB{'formatHeadDEFAULT'} = "<ol>";
> >         $WBB{'formatFootDEFAULT'} = "</ol>";
> >     }
> >     elsif ( $WBB{'formatRowDEFAULT'} eq '' && $WBB{'format;DEFAULT'}
> > eq '' ) {
> > #MF failsafe
> >         $WBB{'formatHeadDEFAULT'} = "<ol>";
> >         $WBB{'formatFootDEFAULT'} = "</ol>";
> >     }
> >
> > But in this code formatHead/FootDEFAULT is allways defined with ordered
> > list, What it is supposed to fix ?
> > Or may be, I've made a mistake while importing your code?
> >
> > (sorry, if I've already asked about this, but I can't find my email)
> >
> > BTW, if it is really a fix, we don't need test agains format;DEFAULT,
> > only this:
> >  if ( $WBB{'formatRowDEFAULT'} eq '' ) {
> >         # $WBB{'formatRowDEFAULT'} = $WBB{"format;DEFAULT"};
> >         $WBB{'formatHeadDEFAULT'} = "<ol>";
> >         $WBB{'formatFootDEFAULT'} = "</ol>";
> >
> > Xavier
> > xavier@xxxxxxxxxxxxxx
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~woda
> > Post to     : woda@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~woda
> > More help   : https://help.launchpad.net/ListHelp
> 

Xavier
xavier@xxxxxxxxxxxxxx



References