woda team mailing list archive

Thread
Date

possible bug with default format

To: woda@xxxxxxxxxxxxxxxxxxx
From: Xavier Brochard <xavier@xxxxxxxxxxxxxx>
Date: Tue, 13 Oct 2009 16:32:52 +0200
Organization: Alternatif
User-agent: KMail/1.12.2 (Linux/2.6.30-2-amd64; KDE/4.3.2; x86_64; ; )

Hi Malcolm


In the code below, you have changed how formatHead/FootDEFAULT is defined:

    # --- defaults and compatibility issues
(...)   
    if ( $WBB{'formatRowDEFAULT'} eq '' && $WBB{'format;DEFAULT'} ne '' ) {
        # $WBB{'formatRowDEFAULT'} = $WBB{"format;DEFAULT"};
        $WBB{'formatHeadDEFAULT'} = "<ol>";
        $WBB{'formatFootDEFAULT'} = "</ol>";
    }
    elsif ( $WBB{'formatRowDEFAULT'} eq '' && $WBB{'format;DEFAULT'} eq '' ) {    
#MF failsafe
        $WBB{'formatHeadDEFAULT'} = "<ol>";
        $WBB{'formatFootDEFAULT'} = "</ol>";
    }

But in this code formatHead/FootDEFAULT is allways defined with ordered list, 
What it is supposed to fix ?
Or may be, I've made a mistake while importing your code?

(sorry, if I've already asked about this, but I can't find my email)

BTW, if it is really a fix, we don't need test agains format;DEFAULT, only 
this:
 if ( $WBB{'formatRowDEFAULT'} eq '' ) {
        # $WBB{'formatRowDEFAULT'} = $WBB{"format;DEFAULT"};
        $WBB{'formatHeadDEFAULT'} = "<ol>";
        $WBB{'formatFootDEFAULT'} = "</ol>";

Xavier
xavier@xxxxxxxxxxxxxx