wikipbx-dev team mailing list archive

[Riccardo Magliocchetti <riccardo.magliocchetti@xxxxxxxxx>]

Il 05/11/2010 14:13, Stas Shtin ha scritto:
> Hi Riccardo,

Hi Stas,

> Please change the branch owner to wikipbx-dev, so that I would be able
> to make some changes myself.

done

> So far it looks good, here are some things
> that can be improved:
>
> 1. Make a separate page and menu entry for contacts exporting.

makes sense

> 2. Add optional "organisation" and "title" fields (varchar(100)). It's
> better to make "notes" varchar(255) instead of text.

ok

> 3. Is there any use case when you would need to export only part of your
> contacts? Maybe we need an ability to filter contacts by organisation
> and search by phone number/name/title. Also, adding checkboxes that can
> be deselected to exclude contacts from being exported seems like a good
> idea to me.

I don't but maybe others have :)

> 4. numbers = models.CharField(_(u"caller ID number"), max_length=25)
>
> So is it one number or multiple? Maybe we should have fields for work
> and home numbers.

I've started with multiple in one field but then moved to one, agree 
need to split at least to home, work and mobile. Even fax maybe?

> 5. When in template you have:
>          {% trans "Caller ID number" %}
>
> and in model:
> _(u"caller ID number")
>
> that creates two localization strings. In order to create only one
> string with correct capitalization in templates, you should write it like:
>
> {{ _("caller ID number")|capfirst }}
>
> It looks somewhat uglier than it should, but I haven't found any better
> solution that works for all cases.

Sure this is an oversight

> 6. Instead of "Siemens Gigaset" format it should be called vCard 2.1. We
> certainly need to add 3.0 before releasing this, but it's probably a
> matter of using a slightly different template. Export page should also
> contain a brief note about which format is used by which phone
> manufacturers, to make it less confusing for the new users.

Ok, but i only have gigaset phones at hand :)

> 7. We could add last_saved field (not editable by user) in order to
> generate REV field in vCard. I guess that some systems are using it in
> order to update vCard info only when it's changed.

agree

> 8. Export templates should be stored in django templates (i.e.
> contacts/templates/vcard_2_1.vcf). Unset entries should be skipped when
> generating exported data to keep file size down.

What do you mean by unset entries?

> 9. If you want to export JSON data only to freeswitch, the decorator
> should be checking for IP address set in event socket rather than only
> localhost. This way you can be using it with freeswitch running on a
> different server.

Yeah, that was the plan; will use that. Does the localhost_only 
decorator would be of any use for other stuff?

> Don't worry about big number of comments and suggestions - I will work
> on some of them myself.

Help appreciated :)

thanks,
riccardo