wikipbx-dev team mailing list archive

[Stas Shtin <antisvin@xxxxxxxxx>]

Hi Riccardo,

Please change the branch owner to wikipbx-dev, so that I would be able
to make some changes myself. So far it looks good, here are some things
that can be improved:

1. Make a separate page and menu entry for contacts exporting.

2. Add optional "organisation" and "title" fields (varchar(100)). It's
better to make "notes" varchar(255) instead of text.

3. Is there any use case when you would need to export only part of your
contacts? Maybe we need an ability to filter contacts by organisation
and search by phone number/name/title. Also, adding checkboxes that can
be deselected to exclude contacts from being exported seems like a good
idea to me.

4. numbers = models.CharField(_(u"caller ID number"), max_length=25)

So is it one number or multiple? Maybe we should have fields for work
and home numbers.

5. When in template you have:
        {% trans "Caller ID number" %}

and in model:
_(u"caller ID number")

that creates two localization strings. In order to create only one
string with correct capitalization in templates, you should write it like:

{{ _("caller ID number")|capfirst }}

It looks somewhat uglier than it should, but I haven't found any better
solution that works for all cases.

6. Instead of "Siemens Gigaset" format it should be called vCard 2.1. We
certainly need to add 3.0 before releasing this, but it's probably a
matter of using a slightly different template. Export page should also
contain a brief note about which format is used by which phone
manufacturers, to make it less confusing for the new users.

7. We could add last_saved field (not editable by user) in order to
generate REV field in vCard. I guess that some systems are using it in
order to update vCard info only when it's changed.

8. Export templates should be stored in django templates (i.e.
contacts/templates/vcard_2_1.vcf). Unset entries should be skipped when
generating exported data to keep file size down.

9. If you want to export JSON data only to freeswitch, the decorator
should be checking for IP address set in event socket rather than only
localhost. This way you can be using it with freeswitch running on a
different server.

Don't worry about big number of comments and suggestions - I will work
on some of them myself.

Stas.