mvhub-dev team mailing list archive

[Lee Goodrich <lgoodrich@xxxxxxxxxx>]

Review: Needs Fixing
Still not quite sure why you're removing the .muttrc instructions from the installation checklist.

The code creating a new config file if it doesn't already exist is unnecessary. The code already handled that condition because when ConfigSimple opens a config file, it'll create it if it doesn't already exist. I tested it when I originally wrote that functionality.

Automating apache and dns setup is nice, but the interface is kinda unintuitive. If you run mv_setup lgoodrich, it does some actions, but if you run sudo mv_setup lgoodrich, it does additional actions. This isn't explained in the usage statement nor is there a warning when running mv_setup without sudo that certain steps are being skipped. Only by scrutinizing the source-code was I able to figure out that certain actions only get run if the command is run as a superuser. Why not add a simple message stating that apache and dns configuration is being skipped and to run the command via sudo if you wish those actions to be performed?
-- 
https://code.launchpad.net/~omacneil/mvhub/improve_brave_add_dev_2010-04-16/+merge/23633
Your team mvhub-dev is subscribed to branch lp:mvhub.