← Back to team overview

millennium-dev team mailing list archive

Re: [Merge] lp:~rafalcieslak256/millenniumduel/cached-redrawing into lp:millenniumduel

 

1) Redrawing it once is cheap, this is just a matter of copying a few small bitmaps, which video cards can do insanely fast. And we can spare it, because swapping the main widget should happen very rarely (or, ideally, just once). And I expect there will not be any good reason to setting the main widget to the same value. Therefore this would be a very very minor change.

2) It may seem that these represent current dimensions. However, within the *only* context where these values are used, namely within Drawable::draw(...), these variable contain values that are already outdated. And since they are not meant to be used anywhere else, I belive this is enough to call them "previous values", as such is their role in draw(...).
-- 
https://code.launchpad.net/~rafalcieslak256/millenniumduel/cached-redrawing/+merge/176962
Your team Millennium Developers is subscribed to branch lp:millenniumduel.


References