millennium-dev team mailing list archive

[Adam Malinowski <delta.7676@xxxxxxxxx>]

Review: Needs Fixing

Beatufil work. Although I wasn't able to notice difference while triggering button 1 and button 2, current version caught a little lag on playing "Quit? No. Quit? ...", whereas your branch was immediate. 

I think I've figured out a single bug: 
Function void Fixed::remove_item needs setting d.parent = nullptr at the end; otherwise, any container will throw exception when requested to add the removed widget. 


I would also like to rediscuss the matter of doubled use of SetNeedsRedrawing() in function 

void LayeredView::HideLayer

 - it first calls 

void OrderedContainer::SetVisibility, 

which also calls SetNeedsRedrawing().

This is clearly redundant and I think it may bring about confusion of code readers.
-- 
https://code.launchpad.net/~rafalcieslak256/millenniumduel/cached-redrawing/+merge/176962
Your team Millennium Developers is subscribed to branch lp:millenniumduel.