millennium-dev team mailing list archive

[Jakub Sękowski <sequba@xxxxxxxxx>]

Review: Needs Fixing

Wow, it really does work faster. It's nice, that you managed to get such an improvement and still keep simplicity of adding new widgets.

However, I have 2 objections:

1) redrawing main widget may be potentially expensive, right? To avoid it when not needed, I suggest to check if new main widget is different to current while setting it:

void Display::SetMainWidget(Drawable& v){
    if(&v != &main_widget) {
        main_widget = &v;
        main_widget_changed = true;
    }
}

2) Why "_previous_height" and "_previous_width" are called so? They're actually CURRENT height and width.
-- 
https://code.launchpad.net/~rafalcieslak256/millenniumduel/cached-redrawing/+merge/176962
Your team Millennium Developers is subscribed to branch lp:millenniumduel.