wikipbx-dev team mailing list archive

[Riccardo Magliocchetti <riccardo.magliocchetti@xxxxxxxxx>]

Il 29/10/2010 21:12, Stas Shtin ha scritto:
> Hi Riccardo,

Hi Stas,

> I've recently added a blueprint on launchpad for something that is
> rather similar to this -
> https://blueprints.launchpad.net/wikipbx/+spec/phone-contacts

I've seen that after sending the mail :)

> I'd say it's better to keep this in a separate app, i.e.
> wikipbx.contacts. I'd prefer to use modular approach when it makes sense.

ok

> Should the vcard config be used as described here -
> http://wiki.freeswitch.org/wiki/XML_User_Directory_Guide#VCards ? It may
> make sense to have a separate model with just peron's phone and name and
> another one for a vcard with all details. Also it looks like it's used
> for defining endpoint's own data rather than other peers, so it could be
> something else.

I plan to use vcard only as export format, not using vcard format as a 
base for the model. My use case is for people without endpoints in the 
system so i don't need them in a relationship.

> Also, it would be a big plus if you add tests to this app - wikipbx
> isn't tested properly yet, but it's better to stick to good practices in
> the new code.

Never written a single line of test code for django apps, will take a 
look at that though.

> I've added a new branch now (wanted to test that sharing branches with a
> team works fine with launchpad), so you should be using it once you get
> to work on this app.

fine

thanks,
riccardo