← Back to team overview

vcs-fast-import-devs team mailing list archive

Re: RFC: Substitution of marks to commit-ids in log messages

 

Ian Clatworthy <ian.clatworthy@xxxxxxxxxxxxx> wrote:
> Shawn O. Pearce wrote:
> > Ian Clatworthy <ian.clatworthy@xxxxxxxxxxxxx> wrote:
> >> Would it be better to explicitly mark commit messages needing expansion?
> >> By using a 'template' command in place of a 'data' command say?
> > 
> > How does that help escaping ":8080" in a commit message that needs
> > this replacement for ":43" but not for ":8080" (as the latter was
> > literally in the source)?
> 
> Good point - it doesn't.
> 
> I was thinking more about stopping accidental interpolation, assuming
> the vast majority of messages wouldn't want it, regardless of whatever
> templating syntax we selected.

Given that, yes, it makes sense to say "template" in place of say
"data", but we still need a way to handle escaping ":8080" as
a literal.  :-)

-- 
Shawn.



References