← Back to team overview

vcs-fast-import-devs team mailing list archive

Re: RFC: Substitution of marks to commit-ids in log messages

 

Shawn O. Pearce wrote:
> Max Bowsher <maxb@xxxxxxx> wrote:

>> I would like to propose that a new importer feature be declared,
>> "commit-message-mark-expansion", in which the importer is expected to
>> substitute substrings of commit messages looking like <{[:12345]}> with
>> the destination VCS's native revision id for the given mark.
> 
> Makes sense.  But what if the message contains a literal :n?  E.g.
> the message:
> 
>   Fixed URLs with non-standard ports like http://foo:8080/
> 
> If we are going to start parsing the message content we probably
> should have some sort of escape that allows the frontend to protect
> some of it from the replacement parsing, so literal :n can be passed
> through at the same time that a different :n is updated with the
> revision identifier.

Would it be better to explicitly mark commit messages needing expansion?
By using a 'template' command in place of a 'data' command say?

Ian C.



Follow ups

References