← Back to team overview

ubuntu-server-iso-testing-dev team mailing list archive

Re: lp:~pwlars/ubuntu-server-iso-testing/download-specified-build into lp:ubuntu-server-iso-testing

 

I propose to add the following modification to your patch, the behaviour for current is exactly the same than today only !current build will be saved into their own folder:

=== modified file 'download-latest-test-iso.py'
--- download-latest-test-iso.py	2013-03-22 14:11:28 +0000
+++ download-latest-test-iso.py	2013-03-22 20:00:33 +0000
@@ -212,6 +212,8 @@
         with lock:
             rc = 0
             l_iso_dir = options.flavor
+            if options.build != 'current':
+                options.isoroot = os.path.join(options.isoroot, options.build)
             l_iso_location = os.path.join(options.isoroot, l_iso_dir,
                                           l_iso_name)
             logging.debug("Checking state of local cache '%s'", l_iso_location)

I admit it is not a fantastic solution but it removes the risk of collision between builds while preserving the compatibility with what is in place today, it doesn't require to modify every single job and doesn't need to handle links between images. Only the validation job must be modified which must be modified anyway because the source of the image on cdimage.u.c changed. What do you think?
-- 
https://code.launchpad.net/~pwlars/ubuntu-server-iso-testing/download-specified-build/+merge/154963
Your team Ubuntu Server Iso Testing Developers is subscribed to branch lp:ubuntu-server-iso-testing.


References