spv-dev team mailing list archive

["C. Bolduc" <claude.bolduc@xxxxxxxxx>]

Review: Needs Fixing
The branch does its purpose. It seems to work well in Windows. However, I think that the gen_ui.py script can still be improved.

Some comments:

  * There is some hardcoded path extension splitting like ui_file[:-3]. Instead, we should use Python functions like os.path.splitext().

  * It is interesting that you removed some of the code duplication in the script. However, there is still some duplications (they were there before). This can lead to subtle incoherence like: "Why the py file paths for the qrc files are in unicode but not the py file paths for the ui files?"

I fixed the above-mentioned problems in the branch
lp:~claude-bolduc/slidepresenterview/fix-ui-files-generation-return-code
However, I am not sure if it helps to clarify the script. The duplication is removed, but I am not convince that it is clearer. What do you think?


-- 
https://code.launchpad.net/~jmartel/slidepresenterview/fix-ui-files-generation-return-code/+merge/28914
Your team SlidePresenterView Development Team is subscribed to branch lp:slidepresenterview.