mvhub-dev team mailing list archive

[Dan MacNeil <dan@xxxxxxxxxx>]

Review: Needs Fixing
The eval tests are 'passing' because the '$got' and $expected are never changed. 

If you change this:


59	+eval { $got = generate_quick_login_url( undef, 2 ) };
60	+$expected = 'http://www.example.com/cgi-bin/mvhub/agency.pl?rm=ql&id=12346';
61	+is( $got, $expected, $test_message );


59  +eval { $got = generate_quick_login_url( 'another_example.com', 1 ) };
60 +$expected = 'http://www.another_example.com/cgi-bin/mvhub/agency.pl?rm=ql&id=12346';
61  +is( $got, $expected, $test_message );

...the test will fail.

$got is never changed because geterate_quick_login_url dies before it can return a value. 


-- 
https://code.launchpad.net/~reddy22222/mvhub/add_quick_login_tests/+merge/28679
Your team MVHub Developers is subscribed to branch lp:mvhub.