mvhub-dev team mailing list archive

[Dan MacNeil <dan@xxxxxxxxxx>]

Review: Approve
looks good enough, approve subjet to these nits

   dump analog files in own dir
    reports/nsp/analog

the conf file should include a 
PAGEINCLUDE *.pl see:

http://www.analog.cx/docs/include.html



#########
These won't be usable by slob dev users, probably no caching occurs if cache file is not writable, which is probably ok since most people won't have  enough data to worry about caching but if this is ever run by non root in production...

241	+DNSFILE /var/cache/analog/dnsfile.txt
242	+DNSLOCKFILE /var/cache/analog/dnsfile.txt.Lock

Should go to $CFG->param(ABSOLUTE_PATH.tmp_dir);

############
Maybe add comment:
408	+ 30 0 * * * root /usr/sbin/apache2ctl graceful
# 
407.5 # restarting apache because we rotate/resolved logs and it is
      # bad karma to keep writing to renamed file



-- 
https://code.launchpad.net/~leegoodrich/mvhub/new_external_reports/+merge/28673
Your team MVHub Developers is subscribed to branch lp:mvhub.