mvhub-dev team mailing list archive

[Dan MacNeil <dan@xxxxxxxxxx>]

Review: Approve
approve, looks good

optional improvements:
In many places replace $FILE with $FILENAME

476	+ my $FILE = '/etc/bind/db.testing123.net';
...
484	+ _append_to_file( $FILE, $line );

as there are other places in our and other's code where $FILE means 'file handle' 

###
nice catch on on

709	 { dest => "/home/$username/.ssh/config",
713	+ permissions => 'u=rw,g=,o=',

#######




-- 
https://code.launchpad.net/~leegoodrich/mvhub/add_tests_to_utils_setup/+merge/27742
Your team MVHub Developers is subscribed to branch lp:mvhub.