← Back to team overview

mvhub-dev team mailing list archive

Re: [Merge] lp:~leegoodrich/mvhub/add_tests_to_utils_setup into lp:mvhub

 

Probably good to check these off explicitly in each commit message 

Should use DBI::Mock throughout as this is the standard, non-homebrew solution. --May not be possible everywhere, but saving work shouldn't be motivation.

Should change: sub _possible_dup_line to '_string_in_file'

Shouldn't prompt for email address and launchpad username over and over. If conf file exists, don't prompt

Shouldn't use "return $_='test_value';"

Should remove IO::File if no longer using.

Should use AutoDie on File::Copy::move

Should Check all modules for core status: ModuleCorelist 
   DBI::Mock
   IPC::System
   Autodie
   Param::Validate
   ???

..update debian test & cpan Bundle
 
Should use Param::Validate for arg checking.

Should look at _append_file() thing I didn't take good notes on.


-- 
https://code.launchpad.net/~leegoodrich/mvhub/add_tests_to_utils_setup/+merge/27742
Your team MVHub Developers is subscribed to branch lp:mvhub.



References