kolibri-discuss team mailing list archive

[Frode Danielsen <frode@xxxxxxx>]

Review: Needs Fixing
Looks good! The only thing that should be fixed is logging exceptions when debug is off, even though an admin email address doesn't exist. As it is now no information about the error will be shown; neither to the user, the site admin or the server log.

While fixing this, I also propose using empty() check on the admin email address instead of isset(), to catch empty strings as well.

Regarding how to report the site name in an email, I think the best option is a 'site' configuration set. This would contain both the admin email address and the site name, as well as possibly other settings? The admin email is to a sysadmin, some apps might have use for a webadmin as well.
-- 
https://code.launchpad.net/~asteinlein/kolibri/exception-handling/+merge/2396
Your team Kolibri Discuss is subscribed to branch lp:kolibri.