jessyink-team team mailing list archive

[Egor Zindy <ezindy@xxxxxxxxx>]

Morning Hannes,

On Sun, Jun 7, 2009 at 9:25 AM, Hannes Hochreiner<hannes@xxxxxxxxxxxxxx> wrote:
> Hi Egor,
>
> I just checked out the file you attached. Looks very nice! There were two
> things I noticed:
>
> *) I was thinking a little bit about what you mentioned about fitting the
> slides to the width or height of the screen. With your changes they fit the
> width of the screen. Before they fitted the height. Could we make this
> switchable, so that people can effectively choose whether they want the
> black bars on the side or on the top and bottom? The code should be there. I
> just don't know how easy it will be to combine the functions.

I'll have to check this when I'm fully awake. We need something that
will fit the window "best", automatically. Like when you resize a
slide and the slide is resized with bars at the top when the window is
too narrow or bars on the sides when the window is too wide.

>
> *) The other thing was just a small regression. For some strange reason the
> arrow keys don't work in Safari on OSX in the example you sent. There is no
> error message or anything and the other keys work. Things seem to work just
> fine in FF on OSX. Very strange.

I've just noticed the regression myself! Both Safari and Chrome are
affected. I am using onkeypress instead of onkeydown. I thought I had
this nailed down (see the wiki), but obviously not. I need to check
what is happening (was just about to use some "alerts").

Talking of Safari, I've also noticed that of all the browsers I have
in windows (firefox 3.0.10, Opera 9/10beta, Chrome, Safari)... Safari
is the slowest to respond to mouseovers (when changing the active
slide using the mouse in index mode).

> Once you are happy with the changes, could you make a branch on launchpad
> where only this feature is added (if I am not mistaken there are also other
> changes in the ui-addition branch and, if possible, I would like to try and
> merge only one feature at a time to make it easier to track progress and
> problems) and propose it for merging?

OK no problems. I knew I should've created a new branch for that!
Three proposed changes in my branch:
* Way keys are handled (when I fix the Webkit problem) will help with
ASCII keys (+,-,i,...)
* mouse wheel for navigation
* way index is displayed

Other than that, it's synced with JessyInk 1.2.0. I'll try and isolate
the third point for starters.

> I can then just pull from that branch
> and merge it into trunk.
>
No problems, I'll do that.

> Great work!

Thanks mate, appreciated!

>
> Cheers,
> Hannes
>
>
> On 7 Jun 2009, at 00:53, Egor Zindy wrote:
>
>> Dear list,
>>
>> I've spent a bit of time today on the index display code to try and
>> break it down into separate functions.
>>
>> Index display is now done in three separate steps (haven't changed the
>> function names):
>> * setViewPort() which defines the numbers of lines and columns in index
>> mode
>> * displayIndex(offset) which displays the index grid given a starting
>> point (the offset) - also resizes / positions the visible slides
>> * indexSetActiveSlide(slide) which greys out the slides in the grid,
>> hides the ones that aren't and shows the given slide as white
>>
>> A function which sets the grid offset and the active slide is defined as
>> * indexSetPageSlide(slide) ... is useful for all key interactions in index
>> mode.
>>
>> Grid dimensions are NOT recalculated when window is resized (maybe
>> will look into it) and also, the packing algorithm in setViewPort only
>> considers the case when INDEX_COLUMNS slides are fitted across the
>> whole window. Means black bars top and bottom, not black bars left and
>> right. At the moment, will crash (I think) if heigt of one thumbnailed
>> slide is greater than height of the window...
>>
>> Tested in Firefox, Safari and Opera, seems to be working fine but
>> maybe not for limit cases. Anyway, see presentation and screenshots
>> attached.
>>
>> I'll update the ui-addition branch when I test a presentation
>> generated from Inkscape.
>>
>> Cheers,
>>
>> Egor<packing_firefox.png><packing_opera.png><packing_safari.png><JessyInk.svg>_______________________________________________
>> Mailing list: https://launchpad.net/~jessyink-team
>> Post to     : jessyink-team@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~jessyink-team
>> More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~jessyink-team
> Post to     : jessyink-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~jessyink-team
> More help   : https://help.launchpad.net/ListHelp
>