jessyink-team team mailing list archive

[Hannes Hochreiner <hannes@xxxxxxxxxxxxxx>]

Hi Egor,

I just checked out the file you attached. Looks very nice! There were  
two things I noticed:

*) I was thinking a little bit about what you mentioned about fitting  
the slides to the width or height of the screen. With your changes  
they fit the width of the screen. Before they fitted the height.  
Could we make this switchable, so that people can effectively choose  
whether they want the black bars on the side or on the top and  
bottom? The code should be there. I just don't know how easy it will  
be to combine the functions.

*) The other thing was just a small regression. For some strange  
reason the arrow keys don't work in Safari on OSX in the example you  
sent. There is no error message or anything and the other keys work.  
Things seem to work just fine in FF on OSX. Very strange.

Once you are happy with the changes, could you make a branch on  
launchpad where only this feature is added (if I am not mistaken  
there are also other changes in the ui-addition branch and, if  
possible, I would like to try and merge only one feature at a time to  
make it easier to track progress and problems) and propose it for  
merging? I can then just pull from that branch and merge it into trunk.

Great work!

Cheers,
Hannes


On 7 Jun 2009, at 00:53, Egor Zindy wrote:

> Dear list,
>
> I've spent a bit of time today on the index display code to try and
> break it down into separate functions.
>
> Index display is now done in three separate steps (haven't changed the
> function names):
> * setViewPort() which defines the numbers of lines and columns in  
> index mode
> * displayIndex(offset) which displays the index grid given a starting
> point (the offset) - also resizes / positions the visible slides
> * indexSetActiveSlide(slide) which greys out the slides in the grid,
> hides the ones that aren't and shows the given slide as white
>
> A function which sets the grid offset and the active slide is  
> defined as
> * indexSetPageSlide(slide) ... is useful for all key interactions  
> in index mode.
>
> Grid dimensions are NOT recalculated when window is resized (maybe
> will look into it) and also, the packing algorithm in setViewPort only
> considers the case when INDEX_COLUMNS slides are fitted across the
> whole window. Means black bars top and bottom, not black bars left and
> right. At the moment, will crash (I think) if heigt of one thumbnailed
> slide is greater than height of the window...
>
> Tested in Firefox, Safari and Opera, seems to be working fine but
> maybe not for limit cases. Anyway, see presentation and screenshots
> attached.
>
> I'll update the ui-addition branch when I test a presentation
> generated from Inkscape.
>
> Cheers,
> Egor<packing_firefox.png><packing_opera.png><packing_safari.png><Jessy 
> Ink.svg>_______________________________________________
> Mailing list: https://launchpad.net/~jessyink-team
> Post to     : jessyink-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~jessyink-team
> More help   : https://help.launchpad.net/ListHelp