genesis-devs team mailing list archive

[David Castellanos <davidcaste@xxxxxxxxx>]

Hi Frederik!

> Looks good. I’d just rename the "File" menu into "Account" and move the
> "Remove" menu item to that menu.

Done! I've moved the "Synchronize" menu into a submenu in "Account"
menu, because I think it makes more sense.

> And regarding the sync_button: I think the menu should not contain radio
> buttons, because this suggests that this is a setting, instead of
> directly triggering an action. And I think the more human readable
> strings from MS are favorable to my hackish "refresh-from-server"
> strings.

Oks, I've changed the strings to something more readable. About the
sync button, I prefer my option. From my point of view, the "sync"
button has an associated action, which is to synchronize the selected
account. The drop-down menu works as a modifier on this action,
because there is a default option (two-way sync) and other non-default
options. We can provide feedback about the selected sync button
behaviour through the tooltip, and the selected element from the
drop-down menu.

If the menu contains actions instead of options, I rise to two
questions. What should be the behavior of the synchronize button?,
Should appear also the "two-way" action along the others in the
drop-down menu? Indeed we can provide feedback too through the button
text and tooltip... I have to think more about it.

For now, I've pushed in launchpad an updated accounts_window.ui file
with the changes you proposed (except the sync button one), and an
updated account_properties.ui file with the weird last notebook page
removed. The next weekend I'll try to finish it.

Cheers!!! :-)