← Back to team overview

genesis-devs team mailing list archive

Re: Account management [was: gtk.Builder migration]

 

Hi David,

Am Sonntag, den 15.11.2009, 20:28 +0100 schrieb David Castellanos: 
> > Wouldn’t it be possible to re-use code and ui definitions to implement
> > both? I’m not sure this is practically doable, but maybe one could split
> > the several pages (assistant) and tabs (properties dialog) into separate
> > ui files and create the assistant/dialog from the same UI information.
> 
> Mmm, I'm not so experienced in PyGTK to do that, but it's be a great
> idea. Undoubtedly both screens share most of the elements and
> functionality. I'll add it to my TODO list.

I’m not a PyGTK guru myself, so I hope one of us will manage to make
that work. ;-)

> > How does one select the active account? If we include a radio button as
> > one column, we could get rid of the “select server” menu. Once syncing
> > multiple accounts is implemented, we could change this into a checkbox,
> > like it currently is in MS.
> 
> My idea was to implement multiple account synchronization altogether,
> because I have it already implemented in MS11 and it isn't too
> difficult to backport it to Genesis. I'm not satisfied with the way I
> implemented 'enable/disable account'  in MS11 because SE doesn't offer
> a clean way to disable an account. I considered an account as
> 'enabled' if at least one of its sources were synchronized, and
> 'disabled' otherwise. The 'enabled' to 'disabled' transition was clear
> because it was only necessary to disable the account origins, but the
> 'disabled' to 'enabled' transition wasn't as simple. What sources
> should be enabled?, there is no simple way of remembering what origins
> where previously enabled. I implemented this feature because the
> original MS had it, and one of the development requirements was to
> support at least all the features that had the old client.

But do we really have to disable accounts in a way that SE understands?
Currently, when there is more than one server configured, Genesis looks
for the 'default_server' property in the genesis.ini. Maybe we could
expand this to contain a list, not only a single item. Then Genesis
could regard accounts in that list as enabled, and absent ones as
disabled.

> IMHO, this feature isn't as important because if an user doesn't want
> to synchronize an account, he can delete it or manually disable its
> sources. If in the future SE adds support for easily enable or disable
> an account, we can add support for it.

But it might be useful to be able to disable an account (so it is not
included in the automatic sync), but sync it manually from the account
manager. So I think it would be useful to have a means of disabling
accounts other than deleting them.

BTW, I just made that icon theme stuff, so current trunk does now
respect the icon theme for the display of the status icon. I just want
to give the icons some more polish. Then I plan to release a 0.4.2. That
will not contain really huge changes, I just wanted to push out a
release for Karmic. I guess I could also include your
desactivate_origins branch, that shouldn’t be too risky.

After the release, I’ll merge the gtkbuilder branch (If you didn’t find
any problems with my changes), and we can start preparing the more
fundamental changes.

Cheers,
Frederik




Follow ups

References