evoteam team mailing list archive

[Launchpad Bug Tracker <571791@xxxxxxxxxxxxxxxxxx>]

** Branch linked: lp:b2evolution/whissip

-- 
check_canonical_url is broken in trunk (tests)
https://bugs.launchpad.net/bugs/571791
You received this bug notification because you are a member of Evoteam,
which is subscribed to b2evolution.

Status in b2evolution: Fix Released

Bug description:
r8616 [1] changed check_canonical_url (without any reason and a lot of other stuff).
I've noticed that it would only replace the first reference now, pinged the mailinglist and it got fixed a bit in r8649 [2].

Still, the tests are failing: http://test.b2evo.net/HEAD/tests/blogs/evocore/file.funcs.simpletest.php

Since there's no real reason mentioned for this change (i.e. some bug), I tend to revert it to the preg_replace-implementation.
If there's a problem, a new test case should have been added instead.

And at the very least I expect to not have such regressions, especially when there are tests for it already!


1: http://bazaar.launchpad.net/%7Evcs-imports/b2evolution/trunk/revision/8616
2. http://bazaar.launchpad.net/%7Evcs-imports/b2evolution/trunk/revision/8649