commonsense team mailing list archive

[Rob Speer <rspeer@xxxxxxx>]

Should they just raise a NotImplementedError instead?

Is there a reason you want to have an object that's neither a DictTensor
nor a DenseTensor? I'm thinking that the *constructor* should raise a
NotImplementedError because it's an abstract class.

** Changed in: divisi
   Importance: Undecided => Low

-- 
Tensors inheriting from Tensor fail at math
https://bugs.launchpad.net/bugs/406567
You received this bug notification because you are a member of
Commonsense Computing, which is the registrant for Divisi.

Status in Divisi: New

Bug description:
The overridden math methods defined in Tensor require methods which are only defined in DictTensor and DenseTensor.  The Tensor base classes math operators are incomplete and inconsistent (case in point __add__ references Tensor.tensor_iadd, which raises AttributeError)