xig-team team mailing list archive

[Sam Spilsbury <sam.spilsbury@xxxxxxxxxxxxx>]

Sam Spilsbury has proposed merging lp:~smspillaz/xig/xig.real-get-property-reply-message-length into lp:xig.

Requested reviews:
  Xig Development Team (xig-team)

For more details, see:
https://code.launchpad.net/~smspillaz/xig/xig.real-get-property-reply-message-length/+merge/89532

The length of the message written out to the client should be the stored message length div bit format.
-- 
https://code.launchpad.net/~smspillaz/xig/xig.real-get-property-reply-message-length/+merge/89532
Your team Xig Development Team is requested to review the proposed merge of lp:~smspillaz/xig/xig.real-get-property-reply-message-length into lp:xig.

=== modified file 'src/xig-server-codec.c'
--- src/xig-server-codec.c	2012-01-10 16:53:17 +0000
+++ src/xig-server-codec.c	2012-01-21 11:58:26 +0000
@@ -3811,17 +3811,17 @@
     default:
     case 8:
         value8 = message->value;
-        for (i = 0; i < message->value_length; i++)
+        for (i = 0; i < length; i++)
             write_card8 (buffer, MAXIMUM_REQUEST_LENGTH, value8[i], &n_written);
         break;
     case 16:
         value16 = message->value;
-        for (i = 0; i < message->value_length; i++)
+        for (i = 0; i < length; i++)
             write_card16 (buffer, MAXIMUM_REQUEST_LENGTH, XIG_SERVER_CODEC (codec)->priv->byte_order, value16[i], &n_written);
         break;
     case 32:
         value32 = message->value;
-        for (i = 0; i < message->value_length; i++)
+        for (i = 0; i < length; i++)
             write_card32 (buffer, MAXIMUM_REQUEST_LENGTH, XIG_SERVER_CODEC (codec)->priv->byte_order, value32[i], &n_written);
         break;
     }