wikipbx-dev team mailing list archive

[Riccardo Magliocchetti <riccardo.magliocchetti@xxxxxxxxx>]

Hello,

i think i've introduced a regression in logger with error(), this is 
what you should see everytime error is called:

Traceback (most recent call last):
  File "/usr/lib/python2.6/logging/__init__.py", line 776, in emit
    msg = self.format(record)
  File "/usr/lib/python2.6/logging/__init__.py", line 654, in format
    return fmt.format(record)
  File "/usr/lib/python2.6/logging/__init__.py", line 436, in format
    record.message = record.getMessage()
  File "/usr/lib/python2.6/logging/__init__.py", line 306, in getMessage
    msg = msg % self.args

Please see the attached patch, it simplifies the function a bit and 
removes the debug print which i think was a leftover.

Since i'm new to wikipbx please tell me if something if it was different 
with log4py.

thanks,
riccardo

=== modified file 'wikipbx/logger.py'
--- wikipbx/logger.py	2010-09-20 18:15:09 +0000
+++ wikipbx/logger.py	2010-09-22 12:38:44 +0000
@@ -26,7 +26,6 @@
 
 import logging
 import traceback
-import StringIO
 
 """
 Log levels:
@@ -52,14 +51,9 @@
     logobj.debug(*messages)
 
 def error(*messages):
-    logobj.debug(*messages)
-    fp = StringIO.StringIO()
-    traceback.print_exc(file=fp)
-    message = fp.getvalue()
-    messageslist = list(messages)
-    messageslist.append("\n")
-    messageslist.append(message)
-    logobj.error(*messageslist)
+    logobj.error(*messages)
+    tb = traceback.format_exc()
+    logobj.error(tb)
 
 def warn(*messages):
     logobj.warning(*messages)