usf-team team mailing list archive

[Kizzo Kilgore <davidpkilgore@xxxxxxxxx>]

Yeah commenting on the modules sounds good for the long run, if a lot
of them don't already have docstrings, and making use of Python's
logging module is good too - I use it a lot and it's really nice.

On Thu, Jan 21, 2010 at 4:28 PM, Edwin Marshall <aspidites@xxxxxxxxx> wrote:
> It is a bit hard for me to say exactly how the code should be structured because I don't (yet) know what purpose all the existing modules play. I agree with a lot of what Kizzo said, but am still undecided about the config files. Throughout this week I will be studying the various modules and comment on them. Once I get a more complete picture of what everything does, I'll make suggestions here, and perhaps make notes in my branch as well.
>
> Initial thoughts:
> * Everything in the source directory is duplicated in usf_media/musics/ogg and thus source can be removed entirely. Doing so shrinks the code base by approx. 8MB.
>
> * Replace debug_utils.py with the builtin module logging (http://docs.python.org/library/logging.html). While debug_utils.py is certainly small and simple, I'm a firm believer in DRY - Don't Repeat Yourself - at least if no external dependencies are added.
>  - The syntax is virtually identical to what you are already using (assuming proper initialization is done). Compare:
>    LOG().log("some warning message")
>    logging.warning("some warning message")
>  - The logging module already covers the various levels of logging neccessary (warning, debug, info, etc)
>  - Networking is already integrated into the logging module, which means log messages could be sent over a network connection
>
> * remove ultimate-smash-friends.zip from doc/. We already have the files so it should be unnecessary to have duplicates of them in a separate location. I think it would be better to have a python script that new the location of everything and build the package.
>  - Obvious advantage of code not being duplicated everywhere.
>  - Not relying on a shell script means that even package building can be cross-platform (for respective systems that is).
>
>
>
> On a completely different note:
>  - I had no idea what loaders did until I took a peek. I REALLY like the idea of memorization to speed up image processing. While I was aware of the concept, I don't think I'd have thought to implement it as a way of boosting performance. Good job on that.
>  - Haven't tested all the levels, but I'm loving the size of them. Lots of room to maneuver.
>  - Unless it's a glitch, it seems some form of smash attach has already been implemented - kudos, as I wasn't expecting anything of the sort so early.
>
> ____________________________________________________________
> FREE 3D MARINE AQUARIUM SCREENSAVER - Watch dolphins, sharks & orcas on your desktop!
> Check it out at http://www.inbox.com/marineaquarium
>
> _______________________________________________
> Mailing list: https://launchpad.net/~usf-team
> Post to     : usf-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~usf-team
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Kizzo Kilgore
Computer Science Undergraduate
San Jose State University