ubuntu-server-iso-testing-dev team mailing list archive

[Jean-Baptiste Lallement <jean-baptiste@xxxxxxxxxx>]

Review: Needs Fixing
There is a typo:
logging_info should be logging.info




Talking about nitpick:
* Why don't you decrement wait_di_syslog until it's <= 0 ? That would save 1 global variable

* the correct syntax for Logger.info is 
Logger.info(msg, *args, **kwargs)
method arguments should be used instead of parameter expansion 

* SLEEP_TIME being 30 seconds, waiting 10 loops should be enough

* and finally, the 2 logical expressions 
22	+ if l_output is None:
23	+     if not seen_di_syslog:

could be merged since there is no branch for the second:
if not (l_output or seen_di_syslog):


But frankly, I'm fine with these points if the syntax error is fixed :)
-- 
https://code.launchpad.net/~ubuntu-server-iso-testing-dev/ubuntu-server-iso-testing/no-di-log/+merge/72460
Your team Ubuntu Server Iso Testing Developers is subscribed to branch lp:ubuntu-server-iso-testing.