trafodion-infrastructure team mailing list archive

Thread
Date

Testing of gerrit commit-message plugin

To: "trafodion-infrastructure@xxxxxxxxxxxxxxxxxxx" <trafodion-infrastructure@xxxxxxxxxxxxxxxxxxx>
From: "Varnau, Steve (Trafodion)" <steve.varnau@xxxxxx>
Date: Tue, 8 Jul 2014 01:35:46 +0000
Accept-language: en-US
Thread-index: Ac+aTDSzD9TF3alGQga1sEpDOzHrVw==
Thread-topic: Testing of gerrit commit-message plugin

Hi,

I restarted gerrit to pick up the new configuration file.  Seems like the line-length checks are partially working.

Gerrit would not let me submit a subject line over 75 characters (as intended):

remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
remote: error: 4a00134: commit subject >75 characters; use shorter first paragraph
To ssh://svarnau@xxxxxxxxxxxxxxxxxxxx:29418/trafodion/sandbox.git
 ! [remote rejected] HEAD -> refs/publish/master/master (Commit length validation failed)
error: failed to push some refs to 'ssh://svarnau@xxxxxxxxxxxxxxxxxxxx:29418/trafodion/sandbox.git'


I also tried to test a message body line over 80 characters. I could not get gerrit to reject that. It took it regardless.
At this point, I'm not following up on that. The subject line is the thing that is easiest to mess up and what I really wanted the plugin to check.  Since that part is working, I guess I'm declaring success.

-Steve