← Back to team overview

subvertpy-users team mailing list archive

Re: [PATCH] Add version fields to _ra for the version of Subversion compiled against

 

On Thu, 2010-09-23 at 17:37 +0200, Dan Villiom Podlaski Christiansen
wrote:
> On 23 Sep 2010, at 17:25, Jelmer Vernooij wrote:
> 
> > On Thu, 2010-09-23 at 15:21 +0200, Dan Villiom Podlaski Christiansen
> > wrote:
> >> # HG changeset patch
> >> # User Dan Villiom Podlaski Christiansen <danchr@xxxxxxxxx>
> >> # Date 1285247033 -7200
> >> # Node ID de1e4e44b03054a50e6f772305f33b76aaf68057
> >> # Parent  028e04fcf8cc408ccf56d2335c9ab94da3f8207b
> >> Add version fields to _ra for the version of Subversion compiled  
> >> against.
> > These are also returned by version(). Why would you like to duplicate
> > them?
> 
> I assume you're referring to subvertpy.wc.version(). That's the  
> version linked against at runtime, whereas these are the version  
> linked against at compile-time. For hgsubversion, we want to ensure  
> that Subvertpy was *linked* against 1.5 or later; otherwise the  
> functions provided by it won't be available.
Ah, ok. That makes sense. 

It would be nice to actually have this visible in the interface though,
having these as constants is confusing - I expect users will have the
same question as I initially had.

Perhaps we can have a api_version() function that returns a similar
tuple to version() but using the constants?

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part


Follow ups

References