subvertpy-users team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxxxx>]

Hi Dan,

On Tue, 2010-09-14 at 19:15 +0200, Dan Villiom Podlaski Christiansen
wrote:
> # HG changeset patch
> # User Dan Villiom Podlaski Christiansen <danchr@xxxxxxxxx>
> # Date 1284483778 -7200
> # Node ID f11c9e3595a00e2e32bc713cd92f46275b1fe6f9
> # Parent  25a25762a53f54431bfa7c723ff80cddb4a700c4
> Turn RemoteAccess.url into a descriptor.
Thanks for the patch; I can see it would be more straightforward to just
change the url attribute rather than to have to call reparent().
However, I don't think making RemoteAccess.url a settable property is a
good idea.

With this change it suddenly becomes impossible to access (even for
readonly access) the url attribute of a RemoteAccess object while that
object is performing an action (ra_get_url uses is_busy).

I don't particularly like "magic" attributes; reparent() is backed by a
network operation, and calling it can mean having to wait for e.g. a TCP
timeout. I personally find this a bit surprising for an attribute.

Cheers,

Jelmer