sts-sponsors team mailing list archive

[Björn Tillenius <mp+438761@xxxxxxxxxxxxxxxxxx>]

Björn Tillenius has proposed merging ~bjornt/maas:bug-2009805-wrong-kvm-ip into maas:master.

Commit message:
LP #2009805: machine deploy install_kvm=True fails

Only consider IPs that have been configured by MAAS when choosing the right IP
for the KVM endpoint.

Previously it considered any IP associated with the interface, including
DISCOVERED ones that where used while commissioning the machine.

I couldn't find a reliable way of testing this. There is already a test
for this, and most likely it failed intermittently.



Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/438761
-- 
Your team MAAS Maintainers is requested to review the proposed merge of ~bjornt/maas:bug-2009805-wrong-kvm-ip into maas:master.

diff --git a/src/metadataserver/api_twisted.py b/src/metadataserver/api_twisted.py
index 1ba61bc..9273e84 100644
--- a/src/metadataserver/api_twisted.py
+++ b/src/metadataserver/api_twisted.py
@@ -284,7 +284,7 @@ def _get_ip_address_for_vmhost(node):
         )
         interface_ids |= new_ids
 
-    ip = node.ip_addresses(
+    ip = node.static_ip_addresses(
         ifaces=Interface.objects.filter(id__in=interface_ids)
     )[0]
     if ":" in ip: