← Back to team overview

spv-dev team mailing list archive

Re: lp:~jmartel/slidepresenterview/fix-ui-files-generation-return-code into lp:slidepresenterview

 

Review: Needs Fixing
It doesn't work if pyuic4 doesn't exit.

Step to reproduce:
 - Move puic4 (sudo mv /usr/bin/pyuic4 /var/tmp/pyuic4)
 - Run gen_ui.py
 - The error is logged but the return code is 0

./tools/gen_ui.py; echo $?
building: /usr/bin/pyuic4 -o [...]
sh: /usr/bin/pyuic4: not found
Command failed: /usr/bin/pyuic4 -o [...]
0

-- 
https://code.launchpad.net/~jmartel/slidepresenterview/fix-ui-files-generation-return-code/+merge/28914
Your team SlidePresenterView Development Team is subscribed to branch lp:slidepresenterview.



Follow ups

References