spv-dev team mailing list archive

["F.-A. Bourbonnais" <bouf10pub@xxxxxxxxxxx>]

Review: Needs Fixing
1. I think that the clean operation should also return the right code

2. Maybe it could be better to raise an exception and use sys.exit only in the main. That way the flow would be more natural and will prevent future possible side effects or surprises.

2. Good thing that you refactor to eliminate duplications about the generation of py files. 

   But I would suggest to place the method  '_generate_py_files' after '_generate_ui' and '_generate_qrc'. That way, we can read the code more like a story (not going up and down).
-- 
https://code.launchpad.net/~jmartel/slidepresenterview/fix-ui-files-generation-return-code/+merge/27392
Your team SlidePresenterView Development Team is subscribed to branch lp:slidepresenterview.