py3exiv2-team team mailing list archive
-
py3exiv2-team team
-
Mailing list archive
-
Message #00002
py3exiv2 libboost_python3 bugfix for review
Hi Everyone,
First of all, thanks for making this great tool available! I was trying to
use this library in a project I am working on in Ubuntu Linux, however I
could not get the library to build. It seems other people ran into this
same problem where setup.py was passing an incorrect name for the
libboost_python3 library for linking.
See the following for some more reference information although I am sure
you are aware of the issue as you recently fixed it for Mac OSX:
https://bugzilla.redhat.com/show_bug.cgi?id=1727305
I've created a branch with a fix for setup.py that appears to work on
Ubuntu Linux. Also I updated some failing tests that were throwing errors
(including adding the missing pickling.py test file).
Can you please review the merge request and see if it is acceptable?
https://code.launchpad.net/~sanelson/py3exiv2/bugfix_boost_python_build/+merge/380864
I also was curious as to the purpose of the setup.py in the root of the
project? It was not in sync with the main setup.py at
py3exiv2/py3exiv2/setup.py and fails to run from that location anyway due
to shifted file paths. As a test in a github fork I made of the project, I
collapsed the whole project down so that the folder structure looked like
the following:
py3exiv2
├── CHANGELOG
├── configure.py
├── DESCRIPTION.rst
├── doc/
├── README
├── setup.py
├── src/
└── test/
The project still built just fine with this structure. I am not a Python
expert, so I'm hoping that I am just uniformed and that there is a good
reason for the current directory structure.
On another side note, are there any plans to migrate this project to git on
launchpad or to github? I found it rather frustrating initially to try to
contribute my changes due to issues with launchpad. I think that this may
discourage other people who want to contribute to the project.
Thanks!
--
Sam Nelson
Email: sanelson@xxxxxxxxxxxxxxxxx