partner-packaging team mailing list archive

[Brian Thomason <brian.thomason@xxxxxxxxxxxxx>]

 1) As mentioned in IRC, I don't think the package name is
appropriate.  There's already a "convirt" package in Ubuntu 10.04,
which may or may not be related to this?  I am totally unclear on the
relationship.  If this partner one is a follow on to the package in
Lucid, and something that could or should install along side the other
one, then "convirt2" might be appropriate.  Think about gcc3 and gcc4
here.  They are two different compilers.  There are reasons that
perhaps some people explicitly need gcc3, or gcc4.  But importantly,
gcc4 is a logical followon to gcc3.  If, instead, as I suspect, this
is totally different software, then add an appendage, like
convirt-enterprise or some such to it


They'd like to keep it this way, and it is indeed a follow on that can be installed side by side.


 2) jquery is in the Ubuntu archive.  The upstream project would
ideally use that, and depend on it, and just symlink it into place
wherever it is that need it.


They said they'd be happy to look into this for the next release, which should come soon as they want to target maverick next.


 3) debian/dirs has several redundant directories.  It can be reduced to:
/var/lib/convirt/identity
/var/lib/convirt/snapshots
/var/log/convirt
/var/lib/updates


Done


 4) debian/dirs - are you sure about /var/lib/updates?


Thanks for the catch. Fixed.

 5) debian/init - this would be a very easy upstart job.  Could you
consider using upstart here?


I tried doing this but it doesn't handle the fork properly. My first script stalled until I discovered "expect fork".  It would then launch it properly but store the wrong pid value.  I'll be happy to dig more into this for the next release but ask that we don't stall on this.


 6) debian/install - anything that's getting installed to
usr/share/doc belongs in debian/doc.


Fixed


 7) lintian -I *deb; lintian -I *dsc - please add/document overrides
for the rest of these, or fix them where possible


Done


Thanks as always Dustin,

-Brian

** Summary changed:

- Please review convirt2 2.0.1d-1lucid7
+ Please review convirt2 2.0.1g-1

-- 
You received this bug notification because you are a member of PP, which
is a direct subscriber.
https://bugs.launchpad.net/bugs/707517

Title:
  Please review convirt2 2.0.1g-1

Status in PP:
  New

Bug description:
  Known issues:

  * They embed copies of javascript libraries
  * The package name is convirt2 but most dirs are convirt - this is due to the fact we didn;t realize there was a convirt package already.  Some basic testing has been done and the 2 appear as though they can live side-by-side without a problem. (convirt stores most of its data in ~ whereas convirt2 uses /var/lib)

  The package can be found in the convirt-isv/ppa private PPA.  You have
  been provided access.

  Thanks Dustin,

  Brian