← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #11726

Re: [Merge] lp:~smpettit/openlp/import-settings into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Needs Fixing
use find() as opposed to count():

    if file_record.find(u'@Invalid') != -1

Also, all local variables should be words_with_underscores, not camelCase.
-- 
https://code.launchpad.net/~smpettit/openlp/import-settings/+merge/73923
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next