← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/preview-edit-custom into lp:openlp

To: mp+64781@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 16 Jun 2011 06:24:52 -0000
In-reply-to: <20110616043635.21208.3364.launchpad@loganberry.canonical.com>
Reply-to: mp+64781@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
This looks fine, but I don't like the space in the signal name. Can you find where the signal is being emitted and add a .replace(' ', '_') please?
-- 
https://code.launchpad.net/~smpettit/openlp/preview-edit-custom/+merge/64781
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~smpettit/openlp/preview-edit-custom into lp:openlp
From: Stevan Pettit, 2011-06-16