openerp-community-reviewer team mailing list archive

[Alejandro Santana <alejandrosantana@xxxxxxxxx>]

Alejandro Santana has proposed merging lp:~alejandrosantana/ocb-server/7.0-server--fix-1220110 into lp:ocb-server.

Commit message:
[FIX] bug1220110: Fixes Linux evaluation on field_type integer

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1220110 in OpenERP Community Backports (Server): "Server crashes executing Duplicate BoM"
  https://bugs.launchpad.net/ocb-server/+bug/1220110

For more details, see:
https://code.launchpad.net/~alejandrosantana/ocb-server/7.0-server--fix-1220110/+merge/214328

Fixes bug 1220110
https://bugs.launchpad.net/openobject-server/+bug/1220110

Adds a evaluation for integers to avoid problems in Linux when evaluating xmlrpclib.MAXINT
Credit goes to Fabio Colognesi (fabio-colognesi), I only tested his solution positively and made the merge proposal.
-- 
https://code.launchpad.net/~alejandrosantana/ocb-server/7.0-server--fix-1220110/+merge/214328
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~alejandrosantana/ocb-server/7.0-server--fix-1220110 into lp:ocb-server.

=== modified file 'openerp/osv/fields.py'
--- openerp/osv/fields.py	2014-03-27 11:12:41 +0000
+++ openerp/osv/fields.py	2014-04-04 19:26:03 +0000
@@ -1138,7 +1138,8 @@
             # This is not needed for stored fields and non-functional integer
             # fields, as their values are constrained by the database backend
             # to the same 32bits signed int limit.
-            result = __builtin__.float(value)
+            if isinstance(value, (int,long)):
+                result = __builtin__.float(value)
         return result
 
     def get(self, cr, obj, ids, name, uid=False, context=None, values=None):