mvhub-dev team mailing list archive

[Dan MacNeil <dan@xxxxxxxxxx>]

Review: Needs Fixing
Merge approval criteria are:

  "better in some way"

and:
  "worse in now ways"

This is better in that /tmp isn't hard coded any more, but very slightly worse in that there is un-needed interpolation and '/'
 
These lines of diff should be:
 
>  37 + { Directory => "$TMP_DIR" } );
>  58 + { Directory => "$tmp_dir/" } )

37 + { Directory => $TMP_DIR } );
58 + { Directory => $tmp_dir } )

-- 
https://code.launchpad.net/~reddy22222/mvhub/session_temp_dir3/+merge/28088
Your team MVHub Developers is subscribed to branch lp:mvhub.