← Back to team overview

mvhub-dev team mailing list archive

Re: [Merge] lp:~leegoodrich/mvhub/update_mv_developer_home_dir into lp:mvhub

 

Review: Approve
better in some way, not (horribly) worse in all ways. 

error msg should include neame of file, type of open tried.

die may be more approreate than croak

273	+ open FILE, ">$file_href->{dest}" or croak "open FILE failed: $!";
274	+ print FILE $file_href->{contents};
275	+ close FILE or croak "close FILE failed: $!";

my $filname=$file_href->{dest}

open FILE, ">$file_href->{dest}" 
    or croak "open $filename failed for writing because: $!";

-- 
https://code.launchpad.net/~leegoodrich/mvhub/update_mv_developer_home_dir/+merge/26343
Your team MVHub Developers is subscribed to branch lp:mvhub.



References