mvhub-dev team mailing list archive

[Priya Ravindran <pthirumal@xxxxxxxxxx>]

Priya Ravindran has proposed merging lp:~priya/mvhub/move_sql_lib_headings into lp:mvhub.

Requested reviews:
  Dan MacNeil (omacneil)


MOved sql query from Headings.pm to sql_select.lib
-- 
https://code.launchpad.net/~priya/mvhub/move_sql_lib_headings/+merge/25348
Your team MVHub Developers is subscribed to branch lp:mvhub.

=== modified file 'app-mvhub/conf/sql_select.lib'
--- app-mvhub/conf/sql_select.lib	2010-05-03 21:01:56 +0000
+++ app-mvhub/conf/sql_select.lib	2010-05-14 17:45:37 +0000
@@ -152,7 +152,17 @@
   cats_with_visible_programs_view c 
 USING (category_id) 
 WHERE 
-  stems_name ~* ?  
+  stems_name ~* ? 
+
+[CATEGORY_HEADING_CATEGORY_X_FETCH_HEADING_CATEGORY]
+SELECT
+   h.heading_name, c.category_id, c.category_name 
+FROM 
+  category c, heading_category h 
+WHERE 
+  h.category_id = c.category_id 
+ORDER BY 
+  h.heading_name, c.category_name
 
 [CATEGORY_PROGRAM_VIEW_HEADING_CATEGORY_X_ID_NAME_COUNT]
 SELECT

=== modified file 'lib-mvhub/lib/MVHub/Headings.pm'
--- lib-mvhub/lib/MVHub/Headings.pm	2009-12-07 20:00:37 +0000
+++ lib-mvhub/lib/MVHub/Headings.pm	2010-05-14 17:45:37 +0000
@@ -77,14 +77,10 @@
 sub _fetch_heading_categories {
 
     my $dbh = MVHub::Utils::DB::get_dbh();
-
-    my $stmt
-        = "SELECT h.heading_name, c.category_id, c.category_name "
-        . "FROM category c, heading_category h "
-        . "WHERE h.category_id = c.category_id "
-        . "ORDER BY h.heading_name, c.category_name ";
-
-    my $rows_aref = $dbh->selectall_arrayref( $stmt, { Slice => {} } );
+    my $sql = MVHub::Utils::DB::get_sql_select_statement(
+        "CATEGORY_HEADING_CATEGORY_X_FETCH_HEADING_CATEGORY");
+
+    my $rows_aref = $dbh->selectall_arrayref( $sql, { Slice => {} } );
 
     my %heading_categories;
     foreach my $row_href (@$rows_aref) {