← Back to team overview

mvhub-dev team mailing list archive

[Merge] lp:~omacneil/mvhub/remove_warnings_from_test_data into lp:mvhub

 

Dan MacNeil has proposed merging lp:~omacneil/mvhub/remove_warnings_from_test_data into lp:mvhub.

Requested reviews:
  MVHub devs with commit rights (mvhub-commit)


The test data is all kinds of not UTF8

If you don't specify an ENCODING when you create a database, you get UTF8 in postgresql 8.3

So if the database is set to UTF8 and the data to load has client_encoding SQL_ASCII  and data in iso-8859-01, ---lots of errors, some of them fatal

So until we clean up the data we create the databases as SQL_ASCII
-- 
https://code.launchpad.net/~omacneil/mvhub/remove_warnings_from_test_data/+merge/24536
Your team MVHub Developers is subscribed to branch lp:mvhub.
=== modified file 'app-mvhub/project-tools/bin/mv_setup'
--- app-mvhub/project-tools/bin/mv_setup	2010-04-30 19:07:35 +0000
+++ app-mvhub/project-tools/bin/mv_setup	2010-04-30 22:06:24 +0000
@@ -483,7 +483,7 @@
         # kludge to avoid 'db being currently being accessed' errs
         sleep 1;
 
-        $sql = qq{CREATE DATABASE "$username.${suffix}" OWNER $username};
+        $sql = qq{CREATE DATABASE "$username.${suffix}" OWNER $username ENCODING='SQL_ASCII' };
         $dbh->do($sql);
 
         load_test_data_for( $dbh, $username, $suffix );

=== modified file 'app-mvhub/project-tools/test_mvh_db.sql'
--- app-mvhub/project-tools/test_mvh_db.sql	2010-03-28 13:07:47 +0000
+++ app-mvhub/project-tools/test_mvh_db.sql	2010-04-30 22:06:24 +0000
@@ -10,7 +10,6 @@
 -- Name: SCHEMA public; Type: COMMENT; Schema: -; Owner: postgres
 --
 
-COMMENT ON SCHEMA public IS 'Standard public schema';
 
 
 SET search_path = public, pg_catalog;
@@ -10001,12 +10000,6 @@
 -- Name: public; Type: ACL; Schema: -; Owner: postgres
 --
 
-REVOKE ALL ON SCHEMA public FROM PUBLIC;
-REVOKE ALL ON SCHEMA public FROM postgres;
-GRANT ALL ON SCHEMA public TO postgres;
-GRANT ALL ON SCHEMA public TO PUBLIC;
-
-
 --
 -- PostgreSQL database dump complete
 --


Follow ups