mvhub-dev team mailing list archive

[Priya Ravindran <pthirumal@xxxxxxxxxx>]

Priya Ravindran has proposed merging lp:~priya/mvhub/move_sql_lib_headings into lp:mvhub.

Requested reviews:
  Dan MacNeil (omacneil)


MOved sql query from Headings.pm to sql_select.lib
-- 
https://code.launchpad.net/~priya/mvhub/move_sql_lib_headings/+merge/24446
Your team MVHub Developers is subscribed to branch lp:mvhub.

=== modified file 'app-mvhub/conf/sql_select.lib'
--- app-mvhub/conf/sql_select.lib	2010-04-29 14:58:08 +0000
+++ app-mvhub/conf/sql_select.lib	2010-04-29 18:16:19 +0000
@@ -143,6 +143,16 @@
 WHERE 
   agency_id = ?
 
+[CATEGORY_HEADING_CATEGORY_X_FETCH_HEADING_CATEGORY]
+SELECT
+   h.heading_name, c.category_id, c.category_name 
+FROM 
+  category c, heading_category h 
+WHERE 
+  h.category_id = c.category_id 
+ORDER BY 
+  h.heading_name, c.category_name
+
 [ALL_NAMES_VIEW_CATS_WITH_VISIBLE_PROGRAMS_VIEW_X_ALL_FOR_SYNONYMS]  
 SELECT 
   a.category_id, a.category_name, a.stems_name, c.program_count 

=== modified file 'lib-mvhub/lib/MVHub/Headings.pm'
--- lib-mvhub/lib/MVHub/Headings.pm	2009-12-07 20:00:37 +0000
+++ lib-mvhub/lib/MVHub/Headings.pm	2010-04-29 18:16:19 +0000
@@ -77,13 +77,8 @@
 sub _fetch_heading_categories {
 
     my $dbh = MVHub::Utils::DB::get_dbh();
-
-    my $stmt
-        = "SELECT h.heading_name, c.category_id, c.category_name "
-        . "FROM category c, heading_category h "
-        . "WHERE h.category_id = c.category_id "
-        . "ORDER BY h.heading_name, c.category_name ";
-
+    my $stmt = 'CATEGORY_HEADING_CATEGORY_X_FETCH_HEADING_CATEGORY';
+ 
     my $rows_aref = $dbh->selectall_arrayref( $stmt, { Slice => {} } );
 
     my %heading_categories;