mvhub-dev team mailing list archive

[Dan MacNeil <dan@xxxxxxxxxx>]

Almost there. Looking 90% good. 

mv_prove -r lib-mvhub/t/Notifications/

FAILS in my enviroment. 

btw, nice cleanup on /var/www/mvhub/$ENV{USER} in various places

It looks like test coverage is merely 98-99%


http://nsp.omacneil.testing123.net/cover/source-code-refactor_reminder_email-lib-mvhub-lib-MVHub-Notifications-pm--condition.html

Test coverage for MVHub::Utils::DB::get_sql_insert_statement()

doesn't handle dies_ok

lib-mvhub/t/Notifications/get_email_constants_from.t has vestigual stuff in __DATA__

lib-mvhub/t/conf/all.conf
   dev_email should not be dan@xxxxxxxxxx
   better to be blank


#######
Small optional nits, not required for approval
#######

     app-mvhub/conf/sql_insert.lib
         -176	AGENCY_INSERT_RECORD
         +176	AGENCY_X_REQUIRED_FIELDS

If the query is in sql_insert.lib , INSERT_RECORD is a bit redundent

ditto PROGRAM_INSERT_RECORD


-- 
https://code.launchpad.net/~leegoodrich/mvhub/refactor_reminder_email/+merge/22548
Your team mvhub-dev is subscribed to branch lp:mvhub.