millennium-dev team mailing list archive

Thread
Date

[Bug 1204286] Re: Margin should be all Drawables' property.

To: millennium-dev@xxxxxxxxxxxxxxxxxxx
From: Rafał Cieślak <rafalcieslak256@xxxxxxxxx>
Date: Sun, 28 Jul 2013 09:22:24 -0000
Reply-to: Bug 1204286 <1204286@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

This is *exactly* the way I would do it. It's a pretty flexible
approach, and it simplifies widget-specific code as much as possible.

I would, however, reconsider naming. Names containing "NoMargin" would
be silly to call, because whatever wants to use them, would imply that
it is interested in a particular version of the width/height.

Maybe names as   "GetMinimalHeight" and "GetTotalMinimalHeight"   or   "GetInnerMinimalHeight" and "GetMinimalHeight" would be more clear. 
Personally, I'd go for the second option, because it can be extended to OnClicked: IDrawable's "OnClicked" would call widget-specific methods "OnMarginClicked" and "OnInnerClicked".
"Insides" instead of "Inner" could do the trick too.

-- 
You received this bug notification because you are a member of
Millennium Developers, which is subscribed to Millennium Duel.
https://bugs.launchpad.net/bugs/1204286

Title:
  Margin should be all Drawables' property.

Status in Millennium Duel - a GUI frontend for Millennium:
  Triaged

Bug description:
  I suggest to add member "margin" and method "SetMargin" to Drawable
  class definition. Why only Boxes may have it?

To manage notifications about this bug go to:
https://bugs.launchpad.net/millenniumduel/+bug/1204286/+subscriptions