millennium-dev team mailing list archive

[Rafał Cieślak <rafalcieslak256@xxxxxxxxx>]

Review: Approve

This looks great to me. I don't see anything that would need fixing before we merge this.

One note though: a silly thing happened in this branch. Due to file renaming order, bzr is convinced that you renamed Box to OrderedContainer, and, separately, recreated Box from scratch.
Of course, what is expected is that Box was left as it was, and you added new OrderedContainer.
I am unsure whether this is because you have done this way (in such case I suggest avoiding that in future, as this caused us to lose Box's history), because bzr got confused and tried to play wise, or because what I see here is correct behavior expected from bzr.

In either case, this is not something we should worry about, I am just pointing out why the Box appears to be a new class added by your branch.

Thanks for your time to implement this! :)
-- 
https://code.launchpad.net/~sequba/millenniumduel/layered-views/+merge/176733
Your team Millennium Developers is subscribed to branch lp:millenniumduel.