lp-scanner-team team mailing list archive

[Mike Heald <mike.heald@xxxxxxxxxxxxx>]

> 203     -                    name in nonstandard_project_teams):
> 204     +                        name in nonstandard_project_teams):
> 
> The indentation seems rather odd here...
> 
> 205                          project_team_grantee = True
> 206                          permissions = grantee["permissions"]
> 207     -                    if ("PRIVATESECURITY" not in permissions
> 208     -                        or permissions["PRIVATESECURITY"] != "ALL"):
> 209     +                    if (name not in private_security_exceptions
> 210     +                            and (
> 
> and here
> 
> 211     +                                "PRIVATESECURITY" not in permissions
> 212     +                                or permissions["PRIVATESECURITY"] !=
> "ALL")):

That's the PEP8 way. If you "fix" the indentation, you get clauses of the conditional statement that line up with the code beneath it, and it makes it hard to see what's part of the conditional and what's part of the code.
-- 
https://code.launchpad.net/~mike-powerthroughwords/lp-scanner/bug-1174157-security-permission-exempt-teams/+merge/164407
Your team The Launchpad Security Scanner Dev Team is requested to review the proposed merge of lp:~mike-powerthroughwords/lp-scanner/bug-1174157-security-permission-exempt-teams into lp:lp-scanner.