← Back to team overview

lp-scanner-team team mailing list archive

Thread
Date

Re: lp:~timrchavez/lp-scanner/lp-scanner-replace-security-contact-check into lp:lp-scanner

To: "Timothy R. Chavez" <timothy.chavez@xxxxxxxxxxxxx>
From: Kevin McDermott <kevin.mcdermott@xxxxxxxxx>
Date: Wed, 24 Apr 2013 13:14:14 -0000
In-reply-to: <20130424040727.15960.46925.launchpad@ackee.canonical.com>
Reply-to: mp+160545@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

+    sharing = lp.load(str(lp._root_uri.append('+services/sharing')))

Use urlparse.urljoin here, it's safer...

Other than that, this looks ok (I'd prefer to see better testing)
-- 
https://code.launchpad.net/~timrchavez/lp-scanner/lp-scanner-replace-security-contact-check/+merge/160545
Your team The Launchpad Security Scanner Dev Team is subscribed to branch lp:lp-scanner.

References

lp:~timrchavez/lp-scanner/lp-scanner-replace-security-contact-check into lp:lp-scanner
From: Timothy R. Chavez, 2013-04-24