← Back to team overview

lightdm-gtk-greeter-team team mailing list archive

Re: [Merge] lp:~profzoom/lightdm-gtk-greeter/add-mate-badge into lp:lightdm-gtk-greeter

 

Review: Needs Fixing

Hi!

First of all thanks for the merge-request. It's a good idea to add a Mate badge to the greeter.
However, the icon you proposed is not ideal:
 * file-size is 10-times as big as any other badge (clean up the svg)
 * the icon is blurry (the lines are not aligned on the grid)

As soon as that's cleaned up, I'm happy to merge it in. If you don't know how to go about doing this, I can help you, but it might take a week or so until I get to it, I'm quite busy atm.
-- 
https://code.launchpad.net/~profzoom/lightdm-gtk-greeter/add-mate-badge/+merge/243069
Your team LightDM Gtk+ Greeter Development Team is subscribed to branch lp:lightdm-gtk-greeter.


Follow ups

References